-
Notifications
You must be signed in to change notification settings - Fork 10
DEV: pixi run lint
improvements
#104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
thanks for fixing this up!! Could you explain why we want |
This comment was marked as resolved.
This comment was marked as resolved.
Ah. It doesn't work at all anymore.
Would it be reasonable to run |
Hmmm. Could we get rid of the I'm really not sure what would be most idiomatic for pixi here. @ruben-arts is it idiomatic to have a task like I know that there are ways to do this by bootstrapping tasks to call tasks in other environments, but I think I'd rather avoid that 😅. |
I've re-enabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @crusaderky, this is a solid improvement now. Would be nice to follow-up if we can find a way to avoid having to specify the environment every time for one of the tasks, but that can wait I guess :)
pixi run lint
improvementspixi run lint
improvements
Hi @lucascolley What I like most is to define tasks only in the features, and only make myself write the Sometimes this means that you have to make the e.g. what you could do is something like this: [tasks]
default = "echo default"
[feature.test.tasks]
test = "echo test"
[feature.lint.tasks]
lint = "echo lint"
[environments]
default = {features = ["test", "lint"], solve-group = "default"}
test = {features = ["test"], solve-group = "default"}
lint = { features = ["lint"], solve-group = "default"} Then in CI run this to minimize the environments
But locally you will have one big know it all environment that can run anything, this also helps with IDE support as you don't require different environments for different code paths. Let me know if this would make sense to you and if you found issues with this approach I should be aware of! |
thanks for the quick response!!
Since I think the main concern is |
pixi run lint
much faster and allow running it on Windows (partially reverts MAINT: various refactoring #101)No need to explicitly specify lint environment anymorepixi run tests